Fix category filtering for "No category" #1181
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Luckily this use case doesn't break the category filtering implementation. It's just an exceptional case which were not considered so far. Also all existing filtering tests continue to run successfully with the required adaptation. However tests were added to cover this use case. In general the category filtering should consider only test-case nodes, but not TestFixtures nodes. The test-case nodes already determines all categories from itself and from its TestFixture to decide if the category filter matches. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes one issue with the category filtering in a special use case (#1147)
If categories have been defined for all methods of a TestFixture and now "No category" is activated for category filtering, the TestFixture will still be displayed in the tree, but without any children. Here's a screenshot:
It's expected that in this case also the TestFixture is filtered out and thus not be displayed in the tree anymore.